Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade terraform to 1.6.3 and google 5.4.0 #815

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

bobcallaway
Copy link
Member

This upgrades the terraform config to use the latest release (1.6.3) and the latest v5 release of the google provider(s).

Also:

  • Adds dependabot (grouped) updates for terraform modules
  • Removes dynamically querying zone data for redis deployments and allows the terraform provider to pick zones given HA configuration
  • Uses a variable for the project_number instead of dynamically querying it each time; this removes lots of messages like this during terraform plan:
# module.sigstore.module.monitoring[0].module.rekor.module.slos[0].google_monitoring_alert_policy.availability_burn_alert["server-availability-api-v1-index-retrieve-post-slow"] will be updated in-place
  ~ resource "google_monitoring_alert_policy" "availability_burn_alert" {
        id                    = "projects/XXXX/alertPolicies/188095884872686092"
        name                  = "projects/XXXX/alertPolicies/188095884872686092"
        # (7 unchanged attributes hidden)

      ~ conditions {
            name         = "projects/XXXX/alertPolicies/188095884872686092/conditions/188095884872687615"
            # (1 unchanged attribute hidden)

          ~ condition_threshold {
              ~ filter          = "select_slo_burn_rate(\"projects/XXXX/services/rekor/serviceLevelObjectives/server-availability-api-v1-index-retrieve-post\", 72h)" -> "select_slo_burn_rate(\"projects/projectsigstore-staging/services/rekor/serviceLevelObjectives/server-availability-api-v1-index-retrieve-post\", 72h)"
                # (3 unchanged attributes hidden)
            }
        }

        # (1 unchanged block hidden)
    }

Signed-off-by: Bob Callaway <[email protected]>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are non-stop!

@bobcallaway bobcallaway merged commit 490624b into sigstore:main Nov 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants